Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Scripts From Build #62

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Exclude Scripts From Build #62

merged 1 commit into from
Sep 24, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented Sep 24, 2024 •
edited by mintbase-codium-pr-agent bot
Loading

PR Type

enhancement

Description

  • Updated tsconfig.json to exclude scripts/fetch-deployments.ts from the build process.
  • Ensured that only TypeScript files in the src directory are included in the build.

Changes walkthrough 📝

Relevant files
Configuration changes
tsconfig.json
Exclude scripts from TypeScript build configuration           

tsconfig.json

  • Removed scripts/fetch-deployments.ts from the include section
  • Ensured only src/**/*.ts is included
  • No changes to the exclude section
    		•  +1/-3     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @bh2smith bh2smith merged commit 15b00d9 into main Sep 24, 2024
    1 check passed
    @bh2smith bh2smith deleted the fix-build branch September 24, 2024 09:58
    @mintbase-codium-pr-agent
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    @mintbase-codium-pr-agent
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Add 'scripts/' directory to the 'exclude' array to ensure scripts are not included in the build

    To ensure that scripts are excluded from the build, explicitly add the 'scripts/'
    directory to the 'exclude' array. This prevents any TypeScript files under the
    'scripts/' directory from being included in the compilation process.

    tsconfig.json [28-30]

     "exclude": [
   "node_modules",
   "dist",
+  "scripts/**/*",
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies a potential issue where scripts might be included in the build process. Adding the 'scripts/' directory to the 'exclude' array improves the configuration by ensuring that these files are not compiled, which aligns with typical project structures and practices.

    		9

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    enhancement New feature or request Review effort [1-5]: 1
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @bh2smith